Remove unnecessary order adjustment for WC queries #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add to readme WC compatibility (last 2 major versions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes an adjustment in the
orderbyparameter that EP was doing on WooCommerce queries and is no longer needed.In older versions of WC (apparently until WC 3.0.9, released in June 2017), it was defaulting to
menu_order title => ASC: https://github.com/woocommerce/woocommerce/blob/3.0.9/includes/class-wc-query.php#L449Newer versions are already ordering by relevance DESC, as ElasticPress does.
Closes #2473
Changelog Entry
Changed: to comply with modern WooCommerce behavior, ElasticPress does not change the orderby parameter anymore.
Credits
Props @felipeelia and @beazuadmin